Advertisement
OGaskellADI

Untitled

Jul 29th, 2024
11
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 1.05 KB | None | 0 0
  1. - Kconfig seems to have a few errors
  2. - Prompts are missing so it wasn't possible to select a series (SC57x, SC58x etc.) from menuconfig
  3. - `select NOP_PHY` seemed to cause errors, I thought it should be `select NOP_PHY if PHY`
  4. - missing something to enable `USB` and `USB_HOST` - get errors in the core USB storage driver otherwise
  5. - Missing board specific Kconfigs - these link to the board specific configs (using SYS_CONFIG_NAME) which are also missing.
  6. - these contain critical config options like which memory chip is used
  7. - Many config options totally missing values (i.e. defined in Kconfig but never given a value) E.g.
  8. - lots of the clock options
  9. - the default environment including commands/variables required to boot the board
  10. - many other config options
  11. - In our repo, these are defined in the defconfig - maybe they were planning to still use the defconfig after upstreaming?
  12. - Adding the board to "mach types"
  13. - Core data and functions such as `board_init`, the memory map, etc. Some things like this are present in soc.c but most are missing.
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement